OADP-6765: docs: add CA Certificate Bundle documentation for ImageStream backups #1974
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
| - ❌ Toggling `backupImages` setting | ||
| - ❌ Adding/removing DPA `spec.backupLocations` unnecessarily | ||
|
|
||
| **Future improvement**: OADP may implement a watch on all BSLs in the namespace (not just owned ones) to automatically detect Non-DPA BSL changes, eliminating the need for manual triggering. Currently, `Owns(&velerov1.BackupStorageLocation{})` only watches OADP-created BSLs. |
There was a problem hiding this comment.
This is an enhancement that we can do now as immediate follow up if necessary.. or later follow up.
…ro-plugin-for-aws Signed-off-by: Tiger Kaovilai <[email protected]>
…m backups Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
kaovilai
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kaovilai: This pull request references OADP-6765 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…tation for ImageStream backups Signed-off-by: Tiger Kaovilai <[email protected]>
…ckups Signed-off-by: Tiger Kaovilai <[email protected]>
…arameters for CA certificate handling Signed-off-by: Tiger Kaovilai <[email protected]>
…eters for CA certificate handling Signed-off-by: Tiger Kaovilai <[email protected]>
|
/lgtm |
|
Will update with current label behavior leaving room for enhancements |
…and CA certificate collection process Signed-off-by: Tiger Kaovilai <[email protected]>
|
|
||
| From `tests/e2e/backup_restore_suite_test.go`: | ||
|
|
||
| **When `backupImages=true`** (line 638-649): |
There was a problem hiding this comment.
Is this reference outdated? The tests/e2e/backup_restore_suite_test.go has 469 lines of code...
Also avoid using lines here when referencing file that is not permanent link.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/4.19-images ci/prow/4.20-ci-index ci/prow/4.20-images ci/prow/images ci/prow/unit-test |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.19-images, ci/prow/4.20-ci-index, ci/prow/4.20-images, ci/prow/images, ci/prow/unit-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Signed-off-by: Tiger Kaovilai [email protected]
Why the changes were made
How to test the changes made