Skip to content

Conversation

weshayutin
Copy link
Contributor

Why the changes were made

https://issues.redhat.com/browse/OADP-6074

How to test the changes made

For now the only way to test is to use the networkpolicy yaml in the docs directory and attempt backup and restore operations.

  • Needs discussion on the content of the policy and how to deploy w/ the bundle.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2025

@weshayutin: This pull request references OADP-6074 which is a valid jira issue.

In response to this:

Why the changes were made

https://issues.redhat.com/browse/OADP-6074

How to test the changes made

For now the only way to test is to use the networkpolicy yaml in the docs directory and attempt backup and restore operations.

  • Needs discussion on the content of the policy and how to deploy w/ the bundle.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kaovilai and mpryc August 14, 2025 20:00
Copy link

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weshayutin
Once this PR has been reviewed and has the lgtm label, please assign dymurray for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I assume that these will be included in the bundle for the next release?

name: default-deny-labelled
```

This policy implements a **default-deny approach** for pods managed by the OADP operator, meaning that by default, all network traffic is blocked except for explicitly allowed connections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this block the OADP CLI from functioning? Did we ever enable the pull-through logs download that @kaovilai had started? Do we need to allow this in some way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revise the default policy later if needed. The download server has not yet been implemented.

@weshayutin
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Oct 9, 2025

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants