Skip to content

[release-4.15] OCPBUGS-63141: revert: client: re-use a single file for building the session instead of randomly named files #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

[release-4.15] OCPBUGS-63141: revert: client: re-use a single file for building the session instead of randomly named files #150

merged 1 commit into from
Oct 21, 2025

Conversation

chrischdi
Copy link
Contributor

Reverts #143

Because #144 is not merged yet

@chrischdi
Revert "[release-4.15] OCPBUGS-63141: client: re-use a single file fo…
e17d54f 
…r building the session instead of randomly named files"
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

@chrischdi: This pull request references Jira Issue OCPBUGS-63141, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #143

Because #144 is not merged yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo
damdo reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/label backport-risk-assessed
/verified bypass

@openshift-ci openshift-ci bot requested review from damdo and elmiko October 21, 2025 12:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Oct 21, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@chrischdi chrischdi changed the title Revert "[release-4.15] OCPBUGS-63141: client: re-use a single file for building the session instead of randomly named files" [release-4.15] OCPBUGS-63141: revert: client: re-use a single file for building the session instead of randomly named files Oct 21, 2025
@damdo
Copy link
Member

damdo commented Oct 21, 2025

/override ci/prow/e2e-aws-operator ci/prow/e2e-aws-serial ci/prow/e2e-aws-upgrade ci/prow/e2e-aws

This is an immediate revert, no need for the e2es to run

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@damdo: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/okd-scos-e2e-aws-ovn

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-aws-upgrade
  • ci/prow/goimports
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/unit
  • pull-ci-openshift-machine-api-provider-aws-main-e2e-aws
  • pull-ci-openshift-machine-api-provider-aws-main-e2e-aws-operator
  • pull-ci-openshift-machine-api-provider-aws-main-e2e-aws-upgrade
  • pull-ci-openshift-machine-api-provider-aws-main-goimports
  • pull-ci-openshift-machine-api-provider-aws-main-golint
  • pull-ci-openshift-machine-api-provider-aws-main-govet
  • pull-ci-openshift-machine-api-provider-aws-main-images
  • pull-ci-openshift-machine-api-provider-aws-main-unit
  • pull-ci-openshift-machine-api-provider-aws-release-4.10-e2e-aws-serial
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-aws-operator ci/prow/e2e-aws-serial ci/prow/e2e-aws-upgrade ci/prow/okd-scos-e2e-aws-ovn ci/prow/e2e-aws

This is an immediate revert, no need for the e2es to run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws, ci/prow/e2e-aws-operator, ci/prow/e2e-aws-serial, ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-operator ci/prow/e2e-aws-serial ci/prow/e2e-aws-upgrade ci/prow/e2e-aws

This is an immediate revert, no need for the e2es to run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Contributor Author

/verified bypass

Reverting too-early merge

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

@chrischdi: The verified label has been added.

In response to this:

/verified bypass

Reverting too-early merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chrischdi
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

@chrischdi: This pull request references Jira Issue OCPBUGS-63141, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-63140 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-63140 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 October 21, 2025 12:43
@openshift-merge-bot openshift-merge-bot bot merged commit 752a9d8 into openshift:release-4.15 Oct 21, 2025
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@chrischdi: Jira Issue Verification Checks: Jira Issue OCPBUGS-63141
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63141 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Reverts #143

Because #144 is not merged yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2025-10-22-222831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@elmiko elmiko Awaiting requested review from elmiko

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@damdo damdo

@sunzhaohua2 sunzhaohua2

@miyadav miyadav

@huali9 huali9

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chrischdi @openshift-ci-robot @damdo @openshift-merge-robot @sunzhaohua2 @miyadav @huali9