WRKLDS-1550: Add pkg/image/registryclient/v2

[tchap]

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc and openshift-apiserver work as that is where this patch has been tested.
See the linked PRs below.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Note for the Reviewer

Although there is a lot of code, there is paradoxically not much to review. All code is actually copied from other sources and imports paths are amended so that the module works as a whole. Tests are also imported from the respective sources.

See the following PRs across our repos for exemplar usage:

• WIP: WRKLDS-1713: Migrate to distribution/[email protected] oc#2036
• WIP: WRKLDS-1599: Update to distribution/[email protected] openshift-apiserver#532

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Add pkg/image/registryclient/v2
This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc work as that is where this patch has been tested.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc work as that is where this patch has been tested.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/image/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc work as that is where this patch has been tested.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Note for the Reviewer

Although there is a lot of code, there is paradoxically not much to review. All code is actually copied from other sources and imports paths are amended so that the module works as a whole. Tests are also imported from the respective sources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc work as that is where this patch has been tested.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Note for the Reviewer

Although there is a lot of code, there is paradoxically not much to review. All code is actually copied from other sources and imports paths are amended so that the module works as a whole. Tests are also imported from the respective sources.

See openshift/oc#2036 to get the context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/hold

until oc tests are fixed in the linked PR.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc work as that is where this patch has been tested.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Note for the Reviewer

Although there is a lot of code, there is paradoxically not much to review. All code is actually copied from other sources and imports paths are amended so that the module works as a whole. Tests are also imported from the respective sources.

See the following PRs across our repos for exemplar usage:

• WIP: WRKLDS-1713: Migrate to distribution/[email protected] oc#2036
• WIP: WRKLDS-1599: Update to distribution/[email protected] openshift-apiserver#532

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This is a separate module that is compatible with
pkg/image/registryclient, but uses distribution/[email protected].

Since distribution/[email protected] has removed the client package being used
by library-go currently, or rather moved it into internal, this patch
includes copying the packages from distribution/v3/internal/client into
registryclient/v2/internal. Some of the logic is exported as required
to make oc and openshift-apiserver work as that is where this patch has been tested.
See the linked PRs below.

So the approach taken was to copy registryclient into registryclient/v2,
then copy distribution/v3/internal/client into
registryclient/v2/internal, then keep exporting functionality so that oc
can be ported to distributions/[email protected] and registryclient/v2.

Generally when a project importing library-go wants to migrate to
the current distribution/v3, they can just import this module instead of
using pkg/image/registryclient. The interface is compatible with
pkg/image/registryclient and all that is needed is changing the import
path.

Note for the Reviewer

Although there is a lot of code, there is paradoxically not much to review. All code is actually copied from other sources and imports paths are amended so that the module works as a whole. Tests are also imported from the respective sources.

See the following PRs across our repos for exemplar usage:

• WIP: WRKLDS-1713: Migrate to distribution/[email protected] oc#2036
• WIP: WRKLDS-1599: Update to distribution/[email protected] openshift-apiserver#532

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tchap]

/remove-lifecycle stale