WIP: OCPBUGS-61376: re-enable HPA tests in OTE suite #2492
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@maxcao13: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maxcao13
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@maxcao13: This pull request references Jira Issue OCPBUGS-61376, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/retest |
|
Yup HPA tests are definitely still failing in parallel. They are still running because of the // Run HPA specific tests which are designed to be run in parallel
kubeTestsExtension.AddSuite(e.Suite{
Name: "kubernetes/autoscaling/hpa",
Parents: []string{
"openshift/conformance/parallel",
},
Qualifiers: []string{`name.contains("[Feature:HPA]")`},
})I need to remove that, but then this requires a separate ci-job for HPA tests to execute at all. I'm not inclined to have a separate suite just for HPA tests because then we would need to have HPA specific jobs for every platform...? Or maybe we can just get away with an AWS only job since HPA shouldn't be any different on other platforms. I would rather fix this, by just having some sort of isolation within the current k8s conformance suites where HPA tests run in parallel in a separate execution isolated from all other parallel tests, but from what I understand this is not possible with how OTE works right now. EDIT: I think we can separate HPA tests in isolation with, but this means that if you run all conformance parallel tests normally without |
maxcao13
force-pushed
the
re-enable-hpa
branch
from
f6bc6f6 to
066ae57
Compare
|
@maxcao13: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Signed-off-by: Max Cao <[email protected]>
maxcao13
force-pushed
the
re-enable-hpa
branch
from
066ae57 to
862d391
Compare
|
@maxcao13: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
I don't know if this will work, but let's try: /testwith openshift/kubernetes/master/e2e-gcp openshift/origin#30411 |
|
/testwith openshift/kubernetes/master/e2e-gcp openshift/origin#30411 This is failing and running into openshift/ci-tools#4769 |
|
/retest HPA tests have now been isolated when using openshift-tests. 🤞 |
|
/test e2e-gcp |
|
@maxcao13: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
WIP