Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

@skonto
Copy link

@skonto skonto commented May 24, 2022

Testing the new logic in openshift-knative/serverless-operator#1578. Need to test this so that tests in #1118 pass again.

@skonto skonto added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@skonto skonto changed the title [TESt-ONLY] Test new logic in S-O install_catalogsource [TEST-ONLY] Test new logic in S-O install_catalogsource May 24, 2022
@openshift-ci openshift-ci bot requested review from alanfx and mgencur May 24, 2022 08:56
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@skonto
Copy link
Author

skonto commented May 24, 2022

/retest

@nak3
Copy link

nak3 commented May 24, 2022

Thank you so much! Let's add this into main.

@skonto skonto mentioned this pull request May 24, 2022
@skonto
Copy link
Author

skonto commented May 24, 2022

infra:

We have been discussing about this with the test team.

@skonto
Copy link
Author

skonto commented May 24, 2022

/retest

1 similar comment
@skonto
Copy link
Author

skonto commented May 24, 2022

/retest

@nak3
Copy link

nak3 commented May 24, 2022

I close this as the patch already merged into main and this change should not effect on OCP version.

@nak3 nak3 closed this May 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

@skonto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants