-
Notifications
You must be signed in to change notification settings - Fork 74
[SRVKS-911] Deploy config-network configmap into knative-serving-ingress namespace #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SRVKS-911] Deploy config-network configmap into knative-serving-ingress namespace #1495
Conversation
|
/retest Eventing error log |
|
/retest |
Do you mean 1.2.5? /lgtm When tests pass will merge. |
Ah sorry, it means Serverless 1.25 (Knative 1.4). |
@pierDipi seen this before? |
|
(Just Rebased) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch is an alternative solution for SRVKS-911.
Since upstream net-kourier controller starts watching config-network
configmap. The configmap and controller must be deploeyd in the same
namespace.
Initially I tried to move net-kourier into knative-serving namespace
as #1483 but deploy config-network in the ingress namespace is much simpler.