Skip to content

Conversation

@nak3
Copy link
Contributor

@nak3 nak3 commented Apr 11, 2022

This patch is an alternative solution for SRVKS-911.

Since upstream net-kourier controller starts watching config-network
configmap. The configmap and controller must be deploeyd in the same
namespace.

Initially I tried to move net-kourier into knative-serving namespace
as #1483 but deploy config-network in the ingress namespace is much simpler.

@openshift-ci openshift-ci bot requested review from lberk and rhuss April 11, 2022 02:03
@nak3
Copy link
Contributor Author

nak3 commented Apr 12, 2022

/cc @skonto @rhuss

@openshift-ci openshift-ci bot requested a review from skonto April 12, 2022 00:05
@nak3
Copy link
Contributor Author

nak3 commented Apr 18, 2022

/retest

Eventing error log

@nak3
Copy link
Contributor Author

nak3 commented Apr 19, 2022

@skonto @rhuss Would you mind taking a look? This change needs the future version (Knative 1.25) but no harm to merge beforehand.

@skonto
Copy link
Collaborator

skonto commented May 12, 2022

/retest

@skonto
Copy link
Collaborator

skonto commented May 12, 2022

@nak3

This change needs the future version (Knative 1.25) but no harm to merge beforehand.

Do you mean 1.2.5?

/lgtm

When tests pass will merge.

@skonto skonto self-assigned this May 12, 2022
@skonto skonto added the lgtm label May 12, 2022
@nak3
Copy link
Contributor Author

nak3 commented May 12, 2022

Do you mean 1.2.5?

Ah sorry, it means Serverless 1.25 (Knative 1.4).

@skonto
Copy link
Collaborator

skonto commented May 12, 2022

Failed  === RUN   TestServerlessUpgrade/VerifyContinualTests/KafkaSinkSourceContinualTest
2022-05-12T13:38:42.651Z	INFO	upgrade/steps.go:95	8.7) Verifying "KafkaSinkSourceContinualTest".
2022-05-12T13:38:42.670Z	INFO	upgrade/functions.go:110	KafkaSinkSourceContinualTest have received a stop event: Stop of KafkaSinkSourceContinualTest
2022-05-12T13:38:42.671Z	INFO	prober/sender.go:95	Remove of sender deployment: wathola-sender
2022-05-12T13:38:48.710Z	INFO	prober/verify.go:64	Waiting for complete report from receiver...
2022-05-12T13:38:48.710Z	INFO	prober/verify.go:231	Deploying

@pierDipi seen this before?

@openshift-ci openshift-ci bot added approved and removed lgtm labels May 12, 2022
@nak3
Copy link
Contributor Author

nak3 commented May 12, 2022

(Just Rebased)

@skonto
Copy link
Collaborator

skonto commented May 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants