-
Notifications
You must be signed in to change notification settings - Fork 341
Bump test only protobuf to 0.13.0 #5553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump test only protobuf to 0.13.0 #5553
Conversation
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
9c6fcbe to
5365f9f
Compare
|
Windows JDK 24 integ tests failing: All with: Unclear how the last test could create a weak password: Retrying CI |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5553 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 408 408
Lines 25390 25390
Branches 3863 3863
=======================================
Hits 18529 18529
+ Misses 4985 4982 -3
- Partials 1876 1879 +3 🚀 New features to boost your workflow:
|
|
Hi @cwperks can you take a look? |
|
@finnegancarroll for dep updates I think we should have a CHANGELOG entry. |
nibix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this because currently the security plugin build is broken due to this version update.
Generally, that IMHO indicates that the security plugin is not a suitable place for having these tests: #5524
5d34dd3
into
opensearch-project:main
Description
Update test only dependency to maintain compatibility with opensearch protobufs 0.13.0.
PR updating protobuf schema on main: opensearch-project/OpenSearch#19007
Issues Resolved
N/A
Testing
IT updates
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.