-
Notifications
You must be signed in to change notification settings - Fork 341
Refactor ResourcePermissions to refer to action groups as access levels #5335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cwperks
merged 14 commits into
opensearch-project:main
from
cwperks:refactor-share-with-action-group
May 16, 2025
Merged
Refactor ResourcePermissions to refer to action groups as access levels #5335
cwperks
merged 14 commits into
opensearch-project:main
from
cwperks:refactor-share-with-action-group
May 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
…of painless Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
spi/src/main/java/org/opensearch/security/spi/resources/sharing/CreatedBy.java
Show resolved
Hide resolved
spi/src/main/java/org/opensearch/security/spi/resources/client/ResourceSharingClient.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/resources/ResourceSharingIndexHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
...va/org/opensearch/sample/resource/actions/transport/RevokeResourceAccessTransportAction.java
Show resolved
Hide resolved
DarshitChanpura
approved these changes
May 15, 2025
derek-ho
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a bit of a refactor on #5281 to refer to action groups as "access levels". In the context of sharable resources, I think access level helps to differentiate these from other action groups as they would be pertinent to sharable resources.
This also fixes a bug in the logic of
ResourceSharing.isSharedWithEveryoneThis PR also continues work from #5322 to remove instances in
SampleResourcePluginLimitedPermissionsTestsandSampleResourcePluginSystemIndexDisabledTestswhich previously used a workaround since core did not support testing with extended plugins.Refactor
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.