Skip to content

Add time field to getStats schema in _common.yml #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Add time field to getStats schema in _common.yml #803

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2235b7
Add time field to getStats schema in _common.yml
hye-on Jan 21, 2025
5fe4310
Update CHANGELOG for GetStats schema changes
hye-on Jan 21, 2025
bb26c8e
Mark getTime as deprecated
hye-on Jan 22, 2025
8521c54
Add x-version-deprecated and x-version-added 2.19 to schema
hye-on Jan 22, 2025
06edbcf
Merge branch 'main' into add-time-to-getStats
dblock Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Added `GET`, `POST /_plugins/_ml/tasks/_search`, `GET /_plugins/_ml/tools`, `tools/{tool_name}` ([#797](https://github.com/opensearch-project/opensearch-api-specification/pull/797))
- Added `POST /_plugins/_ml/agents/{agent_id}/_execute`, `GET /_plugins/_ml/agents/{agent_id}`, `GET`, `POST /_plugins/_ml/agents/_search` ([#798](https://github.com/opensearch-project/opensearch-api-specification/pull/798))
- Added a warning for test file names that don't match the API being tested ([#793](https://github.com/opensearch-project/opensearch-api-specification/pull/793))
- Added `time` field to the `GetStats` schema in `_common.yml` ([#803](https://github.com/opensearch-project/opensearch-api-specification/pull/803))

### Removed
- Removed unsupported `_common.mapping:SourceField`'s `mode` field and associated `_common.mapping:SourceFieldMode` enum ([#652](https://github.com/opensearch-project/opensearch-api-specification/pull/652))
Expand Down
3 changes: 3 additions & 0 deletions spec/schemas/_common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,9 @@ components:
format: int64
getTime:
$ref: '#/components/schemas/Duration'
deprecated: true
Copy link
Collaborator

@Xtansia Xtansia Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have x-version-deprecated: '2.19' as well

time:
$ref: '#/components/schemas/Duration'
Copy link
Collaborator

@Xtansia Xtansia Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have x-version-added: '2.19' as well

time_in_millis:
$ref: '#/components/schemas/DurationValueUnitMillis'
exists_total:
Expand Down