Fix claude model it #4167
Merged
Fix claude model it #4167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
xinyual
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
ylwu-amzn and
zane-neo
as code owners
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
approved these changes
Sep 11, 2025
Collaborator
mingshl
left a comment
mingshl
left a comment
There was a problem hiding this comment.
thanks for taking the fix. the IT passed now
rithin-pullela-aws
approved these changes
Sep 11, 2025
Collaborator
|
for now, we fixed the CI, but since RAG processor has a logic to apply looking for output field based on the model provider, and that logic also needs to change to adapt the the api response format change. |
pyek-bot
approved these changes
Sep 11, 2025
Collaborator
pyek-bot
left a comment
pyek-bot
left a comment
There was a problem hiding this comment.
approving for merge, thanks for the fix!
Contributor
|
Created an issue for the RAG Processor issue: #4168 |
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 12, 2025
* fix model it by replace claude v1/v2 Signed-off-by: xinyual <[email protected]> * remove useless change Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]>
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
brianf-aws
pushed a commit
to brianf-aws/ml-commons
that referenced
this pull request
Oct 24, 2025
* fix model it by replace claude v1/v2 Signed-off-by: xinyual <[email protected]> * remove useless change Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]>
brianf-aws
pushed a commit
to brianf-aws/ml-commons
that referenced
this pull request
Oct 24, 2025
* fix model it by replace claude v1/v2 Signed-off-by: xinyual <[email protected]> * remove useless change Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> Signed-off-by: Brian Flores <[email protected]>
brianf-aws
pushed a commit
to brianf-aws/ml-commons
that referenced
this pull request
Oct 27, 2025
* fix model it by replace claude v1/v2 Signed-off-by: xinyual <[email protected]> * remove useless change Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> Signed-off-by: Brian Flores <[email protected]>
mingshl
pushed a commit
that referenced
this pull request
Oct 27, 2025
* Increment version to 2.19.4-SNAPSHOT Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: Brian Flores <[email protected]> * fix CVE-2025-55163, CVE-2025-48924 (#4298) * address commons-lang3 CVE-2025-48924 Signed-off-by: Brian Flores <[email protected]> * pin netty to 4.2.5.Final version address CVE-2025-55163 Signed-off-by: Brian Flores <[email protected]> * force all subProjects to use updated common-lang3 version Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> * Move HttpClientFactory to common to expose to other components (#4175) * Move HttpClientFactory to common to expose to other componenets Signed-off-by: zane-neo <[email protected]> * optimize code for better maintainability Signed-off-by: zane-neo <[email protected]> * Optimize code and increase UT coverage Signed-off-by: zane-neo <[email protected]> * Address comments Signed-off-by: zane-neo <[email protected]> * Use amazon aws version from opensearch core Signed-off-by: zane-neo <[email protected]> * address comments Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> Signed-off-by: Brian Flores <[email protected]> * use mainline versions.aws via hardcode Signed-off-by: Brian Flores <[email protected]> * address CVE-2025-58057 Signed-off-by: Brian Flores <[email protected]> * fix code format Signed-off-by: Brian Flores <[email protected]> * empty commit to trigger CI Signed-off-by: Brian Flores <[email protected]> * Fix claude model it (#4167) * fix model it by replace claude v1/v2 Signed-off-by: xinyual <[email protected]> * remove useless change Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> Signed-off-by: Brian Flores <[email protected]> * Don't convert schema-defined strings to other types during validation (#3761) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Brian Flores <[email protected]> * fix Cohere IT (#4174) * fix Cohere IT Signed-off-by: xinyual <[email protected]> * apply spotless Signed-off-by: xinyual <[email protected]> * delete useless it Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: Brian Flores <[email protected]> Signed-off-by: zane-neo <[email protected]> Signed-off-by: xinyual <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: zane-neo <[email protected]> Co-authored-by: Xinyuan Lu <[email protected]> Co-authored-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The instant/v2 is not supported in bedrock currently. Change to 3.5 to pass IT.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.