Execution hint documentation added to cardinality agg #9224
Conversation
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Asim Mahmood <[email protected]>
asimmahmood1
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws and
natebower
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@asimmahmood1 FYI: There is another PR on this topic here #8265. |
Yes, I've kept that original commit and add mine on top. I wanted to make sure to provide the warning. |
|
Thanks! So should we close the original PR because this one contains the original commit? |
Yes, we can close the original PR. Note: I don't have permission to. |
|
@asimmahmood1 Is this PR ready for doc review? |
|
Code PR opensearch-project/OpenSearch#17312 has been merged, so this is ready for |
Signed-off-by: Fanit Kolchina <[email protected]>
|
@asimmahmood1 Doc review complete. Moving this PR to editorial review. Is this still slated for 3.0, or is this going into 2.19.1? |
|
Thank you @kolchfa-aws . Its been merged into 2.19.1 as well, and 2.x PR is also open. |
natebower
left a comment
natebower
left a comment
There was a problem hiding this comment.
@kolchfa-aws @asimmahmood1 Just one minor change. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Asim M <[email protected]>
kolchfa-aws
added
v2.19.1
Done but waiting to merge
|
Just to confirm, this should goto 2.19.1, 2.x branch and main/3.0 branch. |
* Execution hint documentation added to cardinality agg Signed-off-by: Siddharth Rayabharam <[email protected]> * Add expert level warning to cardinality execution_hint paramter Signed-off-by: Asim Mahmood <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _aggregations/metric/cardinality.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Asim M <[email protected]> --------- Signed-off-by: Siddharth Rayabharam <[email protected]> Signed-off-by: Asim Mahmood <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Asim M <[email protected]> Co-authored-by: Siddharth Rayabharam <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 2d39e1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#9224) * Execution hint documentation added to cardinality agg Signed-off-by: Siddharth Rayabharam <[email protected]> * Add expert level warning to cardinality execution_hint paramter Signed-off-by: Asim Mahmood <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _aggregations/metric/cardinality.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Asim M <[email protected]> --------- Signed-off-by: Siddharth Rayabharam <[email protected]> Signed-off-by: Asim Mahmood <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Asim M <[email protected]> Co-authored-by: Siddharth Rayabharam <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
4 participants
Description
This PR adds documentation for execution_hint field that is being added for cardinality aggregator introduced in opensearch-project/OpenSearch#17312. Waiting for main repo PR to be merged.
This PR updates #8265
Issues Resolved
Closes #8264
Version
3.0
Frontend features
n/a
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.