-
Notifications
You must be signed in to change notification settings - Fork 623
Adding example to contains data prepper #11356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding example to contains data prepper #11356
Conversation
Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@dlvenable Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! I have a few small comments, but am otherwise good with this change.
_data-prepper/pipelines/contains.md
Outdated
| processor: | ||
| - add_entries: | ||
| entries: | ||
| - key: "has_test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove unnecessary quotes. I suggest this because the abundance of quotes we already have in our documentation is leading to double quotes on the expressions. As you've probably already noticed, this makes it hard to write expressions.
_data-prepper/pipelines/contains.md
Outdated
| - add_entries: | ||
| entries: | ||
| - key: "has_test" | ||
| value_expression: 'contains(/message, "test")' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for using single quotes here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlvenable its actually not necessary, I've removed them now
_data-prepper/pipelines/contains.md
Outdated
| hosts: ["https://opensearch:9200"] | ||
| insecure: true | ||
| username: admin | ||
| password: "admin_pass" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the double quotes.
Signed-off-by: AntonEliatra <[email protected]>
Description
Adding example to contains data prepper
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.