-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC] Upgrade to protobufs 0.24.0 and fix compilation errors #20059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Karen X <[email protected]>
|
❕ Gradle check result for 7e50b84: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20059 +/- ##
============================================
- Coverage 73.25% 73.17% -0.09%
+ Complexity 71615 71557 -58
============================================
Files 5789 5790 +1
Lines 327471 327538 +67
Branches 47168 47184 +16
============================================
- Hits 239905 239681 -224
- Misses 68315 68611 +296
+ Partials 19251 19246 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karen X <[email protected]>
…rcesource to hightlight builder, support DerivedFields Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for 89487ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for c28dcc5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c28dcc5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...c/src/main/java/org/opensearch/transport/grpc/proto/response/search/SearchHitProtoUtils.java
Show resolved
Hide resolved
...a/org/opensearch/transport/grpc/proto/response/document/bulk/BulkItemResponseProtoUtils.java
Show resolved
Hide resolved
varunbharadwaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Thanks for clarifying some of my questions.
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.