Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Nov 20, 2025

Description

  1. Upgrade protobufs version to reflect latest spec and tooling changes
  2. Add missing force_source to Highlight proto utils
  3. Implement DerivedFields for search requests

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❕ Gradle check result for 7e50b84: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.17%. Comparing base (50f2231) to head (c28dcc5).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../request/search/SearchSourceBuilderProtoUtils.java 73.33% 0 Missing and 4 partials ⚠️
...searchexception/OpenSearchExceptionProtoUtils.java 20.00% 3 Missing and 1 partial ⚠️
...oto/request/search/HighlightBuilderProtoUtils.java 66.66% 1 Missing and 1 partial ⚠️
...onse/document/bulk/BulkItemResponseProtoUtils.java 50.00% 0 Missing and 1 partial ⚠️
...se/document/common/DocWriteResponseProtoUtils.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20059      +/-   ##
============================================
- Coverage     73.25%   73.17%   -0.09%     
+ Complexity    71615    71557      -58     
============================================
  Files          5789     5790       +1     
  Lines        327471   327538      +67     
  Branches      47168    47184      +16     
============================================
- Hits         239905   239681     -224     
- Misses        68315    68611     +296     
+ Partials      19251    19246       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❌ Gradle check result for 89487ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for b393263: SUCCESS

@karenyrx karenyrx marked this pull request as ready for review November 21, 2025 01:55
@karenyrx karenyrx requested a review from a team as a code owner November 21, 2025 01:55
@github-actions
Copy link
Contributor

❌ Gradle check result for c28dcc5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for c28dcc5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for c28dcc5: SUCCESS

Copy link
Contributor

@varunbharadwaj varunbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Thanks for clarifying some of my questions.

@karenyrx karenyrx merged commit 3720d9c into opensearch-project:main Nov 21, 2025
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants