-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove unwanted java checks for JDK<21 in build.gradle #19858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for 6d3a876: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <[email protected]>
|
❌ Gradle check result for e805b6f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19858 +/- ##
============================================
+ Coverage 73.08% 73.25% +0.16%
- Complexity 71063 71168 +105
============================================
Files 5754 5754
Lines 325262 325262
Branches 47033 47033
============================================
+ Hits 237732 238255 +523
+ Misses 68380 67870 -510
+ Partials 19150 19137 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping clean up some of these old references to keep the code base up to date :)
I started on some of the work #19631, but also started replacing references to java.security.Policy in the PR as its marked for removal in the JDK and OpenSearchPolicy subclasses it so it needs a replacement at some point.
The changes in this PR LGTM.
|
@cwperks I missed looking at your changes earlier, but I guess your changes will be probably smaller now. |
Description
Since JDK 21 is the minimum Java version required to build up OpenSearch, build checks related to older versions do not hold value in
mainbranch.Related Issues
Resolves nothing, code cleanup.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.