Skip to content

Conversation

@sandeshkr419
Copy link
Member

@sandeshkr419 sandeshkr419 commented Nov 1, 2025

Description

Since JDK 21 is the minimum Java version required to build up OpenSearch, build checks related to older versions do not hold value in main branch.

Related Issues

Resolves nothing, code cleanup.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sandeshkr419 sandeshkr419 marked this pull request as ready for review November 1, 2025 00:53
@sandeshkr419 sandeshkr419 requested a review from a team as a code owner November 1, 2025 00:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

❌ Gradle check result for 6d3a876: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

❌ Gradle check result for e805b6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandesh Kumar <[email protected]>
@sandeshkr419 sandeshkr419 changed the title Remove unwanted java checks for JDK<21 Remove unwanted java checks for JDK<21 in build.gradle Nov 1, 2025
@sandeshkr419 sandeshkr419 added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Nov 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

✅ Gradle check result for 3c888a1: SUCCESS

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.25%. Comparing base (6b35c7c) to head (3c888a1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19858      +/-   ##
============================================
+ Coverage     73.08%   73.25%   +0.16%     
- Complexity    71063    71168     +105     
============================================
  Files          5754     5754              
  Lines        325262   325262              
  Branches      47033    47033              
============================================
+ Hits         237732   238255     +523     
+ Misses        68380    67870     -510     
+ Partials      19150    19137      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping clean up some of these old references to keep the code base up to date :)

I started on some of the work #19631, but also started replacing references to java.security.Policy in the PR as its marked for removal in the JDK and OpenSearchPolicy subclasses it so it needs a replacement at some point.

The changes in this PR LGTM.

@sandeshkr419 sandeshkr419 merged commit 6be5fe9 into opensearch-project:main Nov 3, 2025
42 checks passed
@sandeshkr419 sandeshkr419 deleted the build branch November 3, 2025 13:55
@sandeshkr419
Copy link
Member Author

@cwperks I missed looking at your changes earlier, but I guess your changes will be probably smaller now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants