Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins #19802
Conversation
…AccessController in discovery plugins Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for 0d4c60b: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0d4c60b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for 0896720: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19802 +/- ##
============================================
+ Coverage 73.12% 73.15% +0.03%
- Complexity 71099 71116 +17
============================================
Files 5754 5752 -2
Lines 325296 325277 -19
Branches 47052 47053 +1
============================================
+ Hits 237868 237955 +87
+ Misses 68282 68200 -82
+ Partials 19146 19122 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| } catch (final IOException e) { | ||
| } catch (final Exception e) { | ||
| if (e instanceof IllegalStateException) { |
There was a problem hiding this comment.
Any reason for changing the behavior?
| // only one address: because we explicitly ask for only one via the Ec2HostnameType | ||
| return new InetAddress[] { InetAddress.getByName(metadataResult) }; | ||
| } catch (IOException e) { | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Any reason for changing this or was this unintentional?
(applies to other places as well)
2 participants
Description
Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins.
Replacing all of these calls in a single PR would be a lot to review, so opting to split up the core by subprojects to replace the calls.
Related Issues
Related to #18339
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.