Skip to content

Conversation

@kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Oct 28, 2025

Description

Currently, WildcardFieldMapper has doc_values set to false by default. This default configuration triggers unnecessary exceptions. Also to align with the default settings of other mappings, we will change the default value of doc_values to true.

As we always serialize this parameter, no matter its value, it's also backward compatibility.

Related Issues

Resolves #18678

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 81f4999: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the change_wildcard_default_value branch from b0cc10f to d3e2673 Compare October 28, 2025 16:15
@github-actions
Copy link
Contributor

✅ Gradle check result for d3e2673: SUCCESS

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.16%. Comparing base (8dd1286) to head (f79e947).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/index/mapper/WildcardFieldMapper.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19796      +/-   ##
============================================
+ Coverage     73.12%   73.16%   +0.04%     
- Complexity    71099    71137      +38     
============================================
  Files          5754     5754              
  Lines        325296   325296              
  Branches      47052    47052              
============================================
+ Hits         237868   238003     +135     
+ Misses        68282    68105     -177     
- Partials      19146    19188      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for dda919a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for f79e947: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kkewwei kkewwei merged commit 3005a8c into opensearch-project:main Oct 30, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Search:Relevance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Nested query on wildcard type field will return no result.

2 participants