-
Couldn't load subscription status.
- Fork 2.3k
Change the default value of doc_values in WildcardFieldMapper to true #19796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default value of doc_values in WildcardFieldMapper to true #19796
Conversation
000e887 to
81f4999
Compare
|
❌ Gradle check result for 81f4999: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
b0cc10f to
d3e2673
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19796 +/- ##
============================================
+ Coverage 73.12% 73.16% +0.04%
- Complexity 71099 71137 +38
============================================
Files 5754 5754
Lines 325296 325296
Branches 47052 47052
============================================
+ Hits 237868 238003 +135
+ Misses 68282 68105 -177
- Partials 19146 19188 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rest-api-spec/src/main/resources/rest-api-spec/test/search/270_wildcard_fieldtype_queries.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
|
❌ Gradle check result for dda919a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Froh <[email protected]>
|
❕ Gradle check result for f79e947: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
Currently,
WildcardFieldMapperhasdoc_valuesset tofalseby default. This default configuration triggers unnecessary exceptions. Also to align with the default settings of other mappings, we will change the default value ofdoc_valuesto true.As we always serialize this parameter, no matter its value, it's also backward compatibility.
Related Issues
Resolves #18678
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.