- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.3k
Make truncate filter a normalizer token filter #19779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make truncate filter a normalizer token filter #19779
Conversation
| ❕ Gradle check result for ac51c6c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@             Coverage Diff              @@
##               main   #19779      +/-   ##
============================================
+ Coverage     73.10%   73.17%   +0.06%     
- Complexity    70959    70991      +32     
============================================
  Files          5737     5737              
  Lines        324766   324766              
  Branches      46981    46981              
============================================
+ Hits         237425   237649     +224     
+ Misses        68226    67964     -262     
- Partials      19115    19153      +38     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
This filter may be useful with keyword fields if preferring to truncate the data rather than ignoring it (ignore above). Move and re-purpose the TruncateTokenFilterTests from the server module to analysis-common (the lucene truncate filter has moved to lucene a long time ago). Signed-off-by: David Causse <[email protected]>
ac51c6c    to
    84d46c5      
    Compare
  
    Relates to opensearch-project/OpenSearch#19779 Signed-off-by: David Causse <[email protected]>
Description
This filter may be useful with keyword fields if preferring to truncate the data rather than ignoring it (ignore above).
Move and re-purpose the TruncateTokenFilterTests from the server module to analysis-common (the lucene truncate filter has moved to lucene a long time ago).
Related Issues
Resolves #19778
Check List
[ ] API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.