-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix a flaky test that forces materialization to hit cache #19759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ Gradle check result for e931bbc: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e931bbc to
5e91d97
Compare
|
❌ Gradle check result for 5e91d97: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5e91d97: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Joe Liu <[email protected]>
5e91d97 to
86b2ece
Compare
|
❕ Gradle check result for 86b2ece: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19759 +/- ##
============================================
- Coverage 73.12% 73.10% -0.03%
+ Complexity 70973 70937 -36
============================================
Files 5737 5737
Lines 324767 324767
Branches 46982 46982
============================================
- Hits 237483 237405 -78
- Misses 68151 68264 +113
+ Partials 19133 19098 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
IndexFieldData#load(LeafReaderContext)does not always build and insert the heavy field-data into the shared cache immediately. For some field types/implementations it returns a lightweight wrapper that defers the expensive build until you actually access the values, or until a global/agg path forces construction.Related Issues
Resolves #19730
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.