-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Migrate gRPC transport executor to ForkJoinPool #19685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate gRPC transport executor to ForkJoinPool #19685
Conversation
42def60 to
cb0269f
Compare
|
❌ Gradle check result for cb0269f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cb0269f to
32618f4
Compare
|
❌ Gradle check result for 32618f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
karenyrx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
modules/transport-grpc/src/main/java/org/opensearch/transport/grpc/GrpcPlugin.java
Outdated
Show resolved
Hide resolved
...pc/src/test/java/org/opensearch/transport/grpc/ssl/SecureNetty4GrpcServerTransportTests.java
Show resolved
Hide resolved
32618f4 to
06951a4
Compare
Signed-off-by: yoonjungeun1 <[email protected]>
Signed-off-by: yoonjungeun1 <[email protected]>
Signed-off-by: yoonjungeun1 <[email protected]>
8f95072 to
96c61de
Compare
Signed-off-by: jungeun yoon <[email protected]>
|
❌ Gradle check result for 6fafca3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This PR migrates the gRPC transport executor from
FixedExecutorBuildertoForkJoinPoolExecutorBuilderto improve performance through work-stealing and better load balancing.GrpcPlugin.javato useForkJoinPoolExecutorBuilderinstead ofFixedExecutorBuilderRelated Issues
Resolves #19370
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.