Skip to content

Conversation

@bzhangam
Copy link
Contributor

@bzhangam bzhangam commented Oct 6, 2025

Description

Add a function to SearchPipelineService to check if system generated factory enabled or not so that plugins can consume this function rather than build their own.

Related Issues

Closes #19427

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

❕ Gradle check result for 8f8dbf3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.00%. Comparing base (cb65261) to head (8f8dbf3).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...nsearch/search/pipeline/SearchPipelineService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main   #19545    +/-   ##
==========================================
  Coverage     73.00%   73.00%            
- Complexity    70483    70528    +45     
==========================================
  Files          5717     5719     +2     
  Lines        323021   323205   +184     
  Branches      46790    46812    +22     
==========================================
+ Hits         235826   235963   +137     
+ Misses        68207    68198     -9     
- Partials      18988    19044    +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@owaiskazi19 owaiskazi19 added the backport 3.3 Backport to 3.3 branch label Oct 6, 2025
@owaiskazi19 owaiskazi19 merged commit e638233 into opensearch-project:main Oct 6, 2025
36 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2025
…factory enabled or not. (#19545)

Signed-off-by: Bo Zhang <[email protected]>
(cherry picked from commit e638233)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Oct 6, 2025
…factory enabled or not. (#19545) (#19547)

(cherry picked from commit e638233)

Signed-off-by: Bo Zhang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Oct 7, 2025
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Oct 13, 2025
…factory enabled or not. (opensearch-project#19545)

Signed-off-by: Bo Zhang <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.3 Backport to 3.3 branch enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose isSystemGeneratedFactoryEnabled function in SearchPipelineService

2 participants