Skip to content

Issue #14407 Fix race condition when calling TranslogManager#trimUnreferencedTranslogFiles #19492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Issue #14407 Fix race condition when calling TranslogManager#trimUnreferencedTranslogFiles #19492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1baa26a
Fix race condition when calling TranslogManager#trimUnreferencedTrans…
fdesu Oct 1, 2025
f825d0a
Add CHANGELOG entry
fdesu Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Handle negative search request nodes stats ([#19340](https://github.com/opensearch-project/OpenSearch/pull/19340))
- Remove unnecessary iteration per-shard in request cache cleanup ([#19263](https://github.com/opensearch-project/OpenSearch/pull/19263))
- Fix derived field rewrite to handle range queries ([#19496](https://github.com/opensearch-project/OpenSearch/pull/19496))
- Fix flaky IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex ([#19492](https://github.com/opensearch-project/OpenSearch/pull/19492)))

### Dependencies
- Bump `com.gradleup.shadow:shadow-gradle-plugin` from 8.3.5 to 8.3.9 ([#19400](https://github.com/opensearch-project/OpenSearch/pull/19400))
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/index/engine/NoOpEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public TranslogManager translogManager() {
public void trimUnreferencedTranslogFiles() throws TranslogException {
final Store store = engineConfig.getStore();
store.incRef();
try (ReleasableLock ignored = readLock.acquire()) {
try (ReleasableLock ignored = writeLock.acquire()) {
ensureOpen();
final List<IndexCommit> commits = DirectoryReader.listCommits(store.directory());
if (commits.size() == 1 && translogStats.getTranslogSizeInBytes() > translogStats.getUncommittedSizeInBytes()) {
Expand Down
Loading