Skip to content

Conversation

@ajleong623
Copy link
Contributor

@ajleong623 ajleong623 commented Sep 18, 2025

Description

I noticed that when the flaky test fails, this is because there are too many disjunctions in the IntervalsSource. https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/intervals/Disjunctions.java#L44. What I changed was to detect the number of total disjunctions there would be when combining the list of IntervalsSource earlier in the stack trace and throwing an error if the list of IntervalsSource cannot be combined. I also skipped the test instances that provided the list that would reach this violation.

Related Issues

Resolves #19167

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anthony Leong <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for f3f787e: SUCCESS

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (cef8d98) to head (08180da).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/index/query/IntervalsSourceProvider.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19332      +/-   ##
============================================
- Coverage     72.90%   72.88%   -0.02%     
+ Complexity    70014    69963      -51     
============================================
  Files          5681     5681              
  Lines        321457   321467      +10     
  Branches      46486    46489       +3     
============================================
- Hits         234347   234306      -41     
+ Misses        68187    68178       -9     
- Partials      18923    18983      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Anthony Leong <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 179f819: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 3a9f1bc: SUCCESS

@github-actions
Copy link
Contributor

❌ Gradle check result for 0067121: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 17e59cd: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

❌ Gradle check result for 445ec1f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 7d1319a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Anthony Leong <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 9854648: SUCCESS

@ajleong623
Copy link
Contributor Author

ajleong623 commented Sep 25, 2025

@cwperks The tests have all run and passed. I think I am ready for review and possibly merge. The only times the tests failed were from flaky one.

@github-actions
Copy link
Contributor

✅ Gradle check result for 08180da: SUCCESS

@cwperks cwperks merged commit 89786da into opensearch-project:main Sep 30, 2025
32 of 33 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
* fix flaky integration tests

Signed-off-by: Anthony Leong <[email protected]>

* add unit tests

Signed-off-by: Anthony Leong <[email protected]>

* retry

Signed-off-by: Anthony Leong <[email protected]>

* add changelog entry

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

* retry workflows

Signed-off-by: Anthony Leong <[email protected]>

---------

Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autocut flaky-test Random test failure that succeeds on second run lucene Search Search query, autocomplete ...etc >test-failure Test failure from CI, local build, etc. v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for IntervalQueryBuilderTests

3 participants