-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix Flaky IntervalQueryBuilderTests #19332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky IntervalQueryBuilderTests #19332
Conversation
Signed-off-by: Anthony Leong <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19332 +/- ##
============================================
- Coverage 72.90% 72.88% -0.02%
+ Complexity 70014 69963 -51
============================================
Files 5681 5681
Lines 321457 321467 +10
Branches 46486 46489 +3
============================================
- Hits 234347 234306 -41
+ Misses 68187 68178 -9
- Partials 18923 18983 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 179f819: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 0067121: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
…nSearch into interval-query-IT
Signed-off-by: Anthony Leong <[email protected]>
|
❕ Gradle check result for 17e59cd: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
…nSearch into interval-query-IT
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 445ec1f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 7d1319a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
@cwperks The tests have all run and passed. I think I am ready for review and possibly merge. The only times the tests failed were from flaky one. |
server/src/main/java/org/opensearch/index/query/IntervalsSourceProvider.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
* fix flaky integration tests Signed-off-by: Anthony Leong <[email protected]> * add unit tests Signed-off-by: Anthony Leong <[email protected]> * retry Signed-off-by: Anthony Leong <[email protected]> * add changelog entry Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> * retry workflows Signed-off-by: Anthony Leong <[email protected]> --------- Signed-off-by: Anthony Leong <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
Description
I noticed that when the flaky test fails, this is because there are too many disjunctions in the
IntervalsSource. https://github.com/apache/lucene/blob/main/lucene/queries/src/java/org/apache/lucene/queries/intervals/Disjunctions.java#L44. What I changed was to detect the number of total disjunctions there would be when combining the list ofIntervalsSourceearlier in the stack trace and throwing an error if the list ofIntervalsSourcecannot be combined. I also skipped the test instances that provided the list that would reach this violation.Related Issues
Resolves #19167
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.