-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Merge Rate Limiting #19309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Rate Limiting #19309
Conversation
|
@gbbafna requesting code review. |
|
❌ Gradle check result for 389b54f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for eeb7130: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/common/settings/ClusterSettings.java
Outdated
Show resolved
Hide resolved
eeb7130 to
8e96a82
Compare
|
❌ Gradle check result for 8e96a82: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
8e96a82 to
06398dc
Compare
|
❌ Gradle check result for 06398dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…vel precedence Signed-off-by: Harshita Kaushik <[email protected]>
06398dc to
37e78bc
Compare
Signed-off-by: Harshita Kaushik <[email protected]>
|
❌ Gradle check result for 8973857: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/index/engine/MergeRateLimitingTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/engine/OpenSearchConcurrentMergeScheduler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harshita Kaushik <[email protected]>
Signed-off-by: Harshita Kaushik <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
|
❌ Gradle check result for a430c66: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/index/engine/MergeRateLimitingTests.java
Show resolved
Hide resolved
Signed-off-by: Harshita Kaushik <[email protected]>
Signed-off-by: Harshita Kaushik <[email protected]>
|
❌ Gradle check result for 9f3babb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9f3babb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9f3babb: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <[email protected]>
|
❌ Gradle check result for 1c0f321: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1c0f321: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19309 +/- ##
============================================
- Coverage 73.00% 72.98% -0.02%
+ Complexity 70483 70453 -30
============================================
Files 5717 5717
Lines 323021 323057 +36
Branches 46790 46793 +3
============================================
- Hits 235826 235796 -30
- Misses 68207 68247 +40
- Partials 18988 19014 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harshita Kaushik <[email protected]>
Signed-off-by: Harshita Kaushik <[email protected]> Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Harshita Kaushik <[email protected]>
Description
This PR adds rate limiting capabilities for forced merges in OpenSearch. It introduces both index-level and cluster-level settings to control the maximum throughput of forced merge operations, helping to prevent these resource-intensive operations from overwhelming system resources.
The implementation includes:
index.merge.scheduler.max_force_merge_mb_per_secto control forced merge rate at the index levelcluster.merge.scheduler.max_force_merge_mb_per_secas a fallback when index-level setting is not specifiedThis enhancement gives administrators fine-grained control over forced merge operations, allowing them to balance merge performance against other system operations.
Related Issues
Resolves #[19308]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.