Cache serialised cluster state based on cluster state version and nod…

[SwethaGuptha]

…e version.

Description

As described in #19272, the current implementation for using the serialized cluster state from cache is incorrect when we have nodes from mixed versions joining the cluster. If cluster state version hasn't changed, Ccuster manager node will send the serialized state of node X to node Y even if X and Y are on different OpenSearch version. With this change, the caching is on both cluster state version and node version.

Related Issues

Resolves: #19272

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for df390ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for c11736c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 5038780: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 93a3067: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for fd364e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ec2dea8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 03c3022: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[rajiv-kv]

LGTM.

Please take a look at the build failures.

[SwethaGuptha]

❌ Gradle check result for 03c3022: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test org.opensearch.indices.replication.WarmIndexSegmentReplicationIT.testRestartPrimaryAndReplicaWithDocuments. The test failure isn't related to changes made in the PR.

[github-actions]

❌ Gradle check result for 6d1446b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d2292df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[SwethaGuptha]

❌ Gradle check result for d2292df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Failed test org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex. Flaky test #14407

[github-actions]

❌ Gradle check result for d2292df: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d2292df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for dbf861a: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.97%. Comparing base (cef8d98) to head (dbf861a).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...rg/opensearch/cluster/coordination/JoinHelper.java	79.31%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19307      +/-   ##
============================================
+ Coverage     72.90%   72.97%   +0.07%     
- Complexity    70014    70093      +79     
============================================
  Files          5681     5683       +2     
  Lines        321457   321545      +88     
  Branches      46486    46504      +18     
============================================
+ Hits         234347   234653     +306     
+ Misses        68187    67942     -245     
- Partials      18923    18950      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-19307-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4583c3ad7e22feb9488a816b28fc41616e899f0
# Push it to GitHub
git push --set-upstream origin backport/backport-19307-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-19307-to-2.x.