Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport be8bbe1 from #18925.

… parity with HTTP (#18925)

* [GRPC] Add proper GRPC status code and error handling

Signed-off-by: Karen Xu <[email protected]>

* rename Http to Rest, group together some convertRestToGrpcStatus codes

Signed-off-by: Karen Xu <[email protected]>

* make final

Signed-off-by: Karen Xu <[email protected]>

---------

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen X <[email protected]>
(cherry picked from commit be8bbe1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner August 8, 2025 16:22
Signed-off-by: Andrew Ross <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

✅ Gradle check result for 5226e87: SUCCESS

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 88.50575% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (7ff34ac) to head (5226e87).
⚠️ Report is 4 commits behind head on 3.2.

Files with missing lines Patch % Lines
...transport/grpc/util/RestToGrpcStatusConverter.java 82.60% 3 Missing and 1 partial ⚠️
...rt/grpc/listeners/SearchRequestActionListener.java 50.00% 3 Missing ⚠️
...ensearch/transport/grpc/util/GrpcErrorHandler.java 93.54% 1 Missing and 1 partial ⚠️
...src/main/java/org/opensearch/ExceptionsHelper.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #18990      +/-   ##
============================================
+ Coverage     72.93%   72.95%   +0.01%     
- Complexity    69352    69407      +55     
============================================
  Files          5643     5645       +2     
  Lines        318713   318779      +66     
  Branches      46112    46123      +11     
============================================
+ Hits         232441   232550     +109     
+ Misses        67488    67440      -48     
- Partials      18784    18789       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 45e0fab into 3.2 Aug 8, 2025
34 of 35 checks passed
@andrross andrross deleted the backport/backport-18925-to-3.2 branch August 8, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants