Skip to content

Conversation

@willyborankin
Copy link
Contributor

Description

Bump gradle to 8.14.3

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@willyborankin willyborankin force-pushed the bump-gradle-to-8-14-3 branch from ef929c1 to 1d114da Compare August 5, 2025 10:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

✅ Gradle check result for 1d114da: SUCCESS

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (9e49930) to head (880e32d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18919      +/-   ##
============================================
+ Coverage     72.74%   72.83%   +0.09%     
- Complexity    68840    68868      +28     
============================================
  Files          5601     5601              
  Lines        316394   316394              
  Branches      45872    45872              
============================================
+ Hits         230155   230441     +286     
+ Misses        67599    67297     -302     
- Partials      18640    18656      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willyborankin willyborankin marked this pull request as ready for review August 5, 2025 13:17
@willyborankin willyborankin requested a review from a team as a code owner August 5, 2025 13:17
cwperks
cwperks previously approved these changes Aug 5, 2025
@cwperks cwperks dismissed their stale review August 5, 2025 14:05

Failure in Detect Breaking Changes

@cwperks
Copy link
Member

cwperks commented Aug 5, 2025

Not exactly sure why, but Detect Breaking Changes is failing here: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/build.gradle#L42-L45

@cwperks
Copy link
Member

cwperks commented Aug 5, 2025

@willyborankin I think you need to update the version here as well: https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/detect-breaking-change.yml#L18

Signed-off-by: Andrey Pleskach <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 880e32d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@willyborankin
Copy link
Contributor Author

I think test failures are not related to changes

@prudhvigodithi
Copy link
Member

I think test failures are not related to changes

The failures could be because of flaky tests, usually the automation should link the flaky tests to this PR (https://build.ci.opensearch.org/job/gradle-check-flaky-test-detector). Let me re-run the Gradle check run.

@willyborankin
Copy link
Contributor Author

I think test failures are not related to changes

The failures could be because of flaky tests, usually the automation should link the flaky tests to this PR (https://build.ci.opensearch.org/job/gradle-check-flaky-test-detector). Let me re-run the Gradle check run.

Thank you

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

✅ Gradle check result for 880e32d: SUCCESS

@reta reta merged commit 42a09e1 into opensearch-project:main Aug 5, 2025
37 of 40 checks passed
@cwperks
Copy link
Member

cwperks commented Aug 5, 2025

We should revert the changes to min Gradle here to allow plugins to use lower versions if they have not yet updated to 8.14.3.

@DarshitChanpura can you post a link to the failing check?

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Aug 5, 2025

@willyborankin @andrross @reta @cwperks @prudhvigodithi This PR is causing build failures in downstream security plugin:

* Where:
Build file '/home/runner/work/security/security/build.gradle' line: 81
* What went wrong:
A problem occurred evaluating root project 'opensearch-security'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
   > Gradle 8.14.3+ is required

https://github.com/opensearch-project/security/actions/runs/16760306911/job/47453742255?pr=5530

@prudhvigodithi
Copy link
Member

With the code freeze for 3.2.0 today https://opensearch.org/releases/, should we revert this and target for 3.3.0 release?

@reta
Copy link
Contributor

reta commented Aug 5, 2025

@prudhvigodithi @DarshitChanpura One sec, fixing

@DarshitChanpura
Copy link
Member

@DarshitChanpura
Copy link
Member

closing #18932 in lieu of #18933

vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants