-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bump gradle to 8.14.3 #18919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gradle to 8.14.3 #18919
Conversation
ef929c1 to
1d114da
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18919 +/- ##
============================================
+ Coverage 72.74% 72.83% +0.09%
- Complexity 68840 68868 +28
============================================
Files 5601 5601
Lines 316394 316394
Branches 45872 45872
============================================
+ Hits 230155 230441 +286
+ Misses 67599 67297 -302
- Partials 18640 18656 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not exactly sure why, but Detect Breaking Changes is failing here: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/build.gradle#L42-L45 |
|
@willyborankin I think you need to update the version here as well: https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/detect-breaking-change.yml#L18 |
1d114da to
880e32d
Compare
Signed-off-by: Andrey Pleskach <[email protected]>
|
❌ Gradle check result for 880e32d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
I think test failures are not related to changes |
The failures could be because of flaky tests, usually the automation should link the flaky tests to this PR (https://build.ci.opensearch.org/job/gradle-check-flaky-test-detector). Let me re-run the Gradle check run. |
Thank you |
|
We should revert the changes to min Gradle here to allow plugins to use lower versions if they have not yet updated to 8.14.3. @DarshitChanpura can you post a link to the failing check? |
|
@willyborankin @andrross @reta @cwperks @prudhvigodithi This PR is causing build failures in downstream security plugin: * Where:
Build file '/home/runner/work/security/security/build.gradle' line: 81
* What went wrong:
A problem occurred evaluating root project 'opensearch-security'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
> Gradle 8.14.3+ is required |
|
With the code freeze for 3.2.0 today https://opensearch.org/releases/, should we revert this and target for 3.3.0 release? |
|
@prudhvigodithi @DarshitChanpura One sec, fixing |
Signed-off-by: Andrey Pleskach <[email protected]>
Description
Bump gradle to 8.14.3
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.