Skip to content

Conversation

@animodak7
Copy link
Contributor

@animodak7 animodak7 commented Jul 16, 2025

Description

Fix for bug issue #13798

  1. Updated listener for skip_unavailable cluster setting

Related Issues

Resolves #13798

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Search Search query, autocomplete ...etc labels Jul 16, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 7f8f8ce: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f962187: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for b2260f6: SUCCESS

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.90%. Comparing base (f81d75a) to head (7302ae1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18766      +/-   ##
============================================
+ Coverage     72.86%   72.90%   +0.03%     
- Complexity    69411    69444      +33     
============================================
  Files          5647     5647              
  Lines        319166   319166              
  Branches      46165    46165              
============================================
+ Hits         232565   232674     +109     
+ Misses        67779    67599     -180     
- Partials      18822    18893      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@animodak7 animodak7 marked this pull request as ready for review July 23, 2025 05:15
@animodak7 animodak7 requested review from a team and peternied as code owners July 23, 2025 05:15
@github-actions
Copy link
Contributor

❌ Gradle check result for 26742df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for e72afa0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 8ff1e9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 661e965: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Aniket Modak <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 565662e: SUCCESS

Signed-off-by: Aniket Modak <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❕ Gradle check result for 7bf6e7f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

❌ Gradle check result for 6f68f76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Aniket Modak <[email protected]>
Signed-off-by: Aniket Modak <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 87838f6: SUCCESS

@github-actions
Copy link
Contributor

❌ Gradle check result for c43a700: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for c43a700: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 10ce5f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b67d53b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 5e8e362: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Aniket Modak <[email protected]>
Signed-off-by: Aniket Modak <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 7302ae1: SUCCESS

@bharath-techie bharath-techie merged commit c442cce into opensearch-project:main Aug 20, 2025
31 checks passed
atris pushed a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
…e drop (opensearch-project#18766)

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

---------

Signed-off-by: Aniket Modak <[email protected]>
Signed-off-by: Aniket Modak <[email protected]>
Co-authored-by: Aniket Modak <[email protected]>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…e drop (opensearch-project#18766)

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

---------

Signed-off-by: Aniket Modak <[email protected]>
Signed-off-by: Aniket Modak <[email protected]>
Co-authored-by: Aniket Modak <[email protected]>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…e drop (opensearch-project#18766)

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

* fix skip_unavailable setting changing to default during node drop issue#13798

Signed-off-by: Aniket Modak <[email protected]>

---------

Signed-off-by: Aniket Modak <[email protected]>
Signed-off-by: Aniket Modak <[email protected]>
Co-authored-by: Aniket Modak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Search Search query, autocomplete ...etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cross Cluster Search is not returning partial result in case of skip_unavailable is true

2 participants