-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Added support for range version support in semver #18557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cwperks
merged 3 commits into
opensearch-project:main
from
shrugarg-amzn:feature/range-for-semver
Jul 7, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
libs/core/src/main/java/org/opensearch/semver/expr/Range.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| */ | ||
|
|
||
| package org.opensearch.semver.expr; | ||
|
|
||
| import org.opensearch.Version; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Expression to evaluate version compatibility within a specified range with configurable bounds. | ||
| */ | ||
| public class Range implements Expression { | ||
| private final Version lowerBound; | ||
| private final Version upperBound; | ||
| private final boolean includeLower; | ||
| private final boolean includeUpper; | ||
|
|
||
| public Range() { | ||
| this.lowerBound = Version.fromString("0.0.0"); // Minimum version | ||
| this.upperBound = Version.fromString("999.999.999"); // Maximum version | ||
| this.includeLower = true; // Default to inclusive bounds | ||
| this.includeUpper = true; | ||
| } | ||
|
|
||
| public Range(Version lowerBound, Version upperBound, boolean includeLower, boolean includeUpper) { | ||
| if (lowerBound == null) { | ||
| throw new IllegalArgumentException("Lower bound cannot be null"); | ||
| } | ||
| if (upperBound == null) { | ||
| throw new IllegalArgumentException("Upper bound cannot be null"); | ||
| } | ||
| if (lowerBound.after(upperBound)) { | ||
| throw new IllegalArgumentException("Lower bound must be less than or equal to upper bound"); | ||
| } | ||
| this.lowerBound = lowerBound; | ||
| this.upperBound = upperBound; | ||
| this.includeLower = includeLower; | ||
| this.includeUpper = includeUpper; | ||
| } | ||
|
|
||
| public void updateRange(Range other) { | ||
| if (other == null) { | ||
| throw new IllegalArgumentException("Range cannot be null"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public boolean evaluate(final Version rangeVersion, final Version versionToEvaluate) { | ||
|
|
||
| boolean satisfiesLower = includeLower ? versionToEvaluate.onOrAfter(lowerBound) : versionToEvaluate.after(lowerBound); | ||
|
|
||
| boolean satisfiesUpper = includeUpper ? versionToEvaluate.onOrBefore(upperBound) : versionToEvaluate.before(upperBound); | ||
|
|
||
| return satisfiesLower && satisfiesUpper; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| Range range = (Range) o; | ||
| return includeLower == range.includeLower | ||
| && includeUpper == range.includeUpper | ||
| && Objects.equals(lowerBound, range.lowerBound) | ||
| && Objects.equals(upperBound, range.upperBound); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(lowerBound, upperBound, includeLower, includeUpper); | ||
| } | ||
|
|
||
| public boolean isIncludeLower() { | ||
| return includeLower; | ||
| } | ||
|
|
||
| public boolean isIncludeUpper() { | ||
| return includeUpper; | ||
| } | ||
|
|
||
| public Version getLowerBound() { | ||
| return lowerBound; | ||
| } | ||
|
|
||
| public Version getUpperBound() { | ||
| return upperBound; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.