Add a dynamic setting to change skip_cache_factor and min_frequency for querycache

[kkewwei]

Description

[Describe what this change achieves]

Related Issues

Resolves #17736

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for bb809f7: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.84%. Comparing base (c9eb7fb) to head (8d62e50).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/org/opensearch/indices/IndicesQueryCache.java	95.34%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18351      +/-   ##
============================================
- Coverage     73.00%   72.84%   -0.16%     
+ Complexity    69518    69427      -91     
============================================
  Files          5648     5648              
  Lines        319230   319272      +42     
  Branches      46174    46183       +9     
============================================
- Hits         233039   232567     -472     
- Misses        67346    67929     +583     
+ Partials      18845    18776      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❌ Gradle check result for 649c936: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 649c936: SUCCESS

[github-actions]

✅ Gradle check result for 628d631: SUCCESS

[kkewwei]

@msfroh @sgup432 @sandeshkr419 I apologize for the inconvenience, could someone please help merge the code? The merge button is grey on my side due to failing merge requirements.

[msfroh]

@kkewwei -- just saw this notification now. I'll take a look tomorrow. If I forget, please tag me again.

[github-actions]

✅ Gradle check result for 04975a0: SUCCESS

[kkewwei]

@kkewwei -- just saw this notification now. I'll take a look tomorrow. If I forget, please tag me again.

@msfroh Tag 😊, please review in your spare time.

[github-actions]

❌ Gradle check result for 8ca9726: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 8ca9726: SUCCESS

[github-actions]

✅ Gradle check result for fe28eb4: SUCCESS

[kkewwei]

@msfroh Tag you again😊

[sgup432]

@msfroh Can you take a look at this?
@kkewwei You might have to resolve conflicts on this one!

[msfroh]

I really like how isolated this is. I think it's a great change and highlights how tweakable the caching behavior can be. (Of course, we'll need to be careful that we don't expose too many settings, but these seem useful.)

[github-actions]

✅ Gradle check result for 8d62e50: SUCCESS

[kkewwei]

Next, I will add the settings in the document:

• https://github.com/opensearch-project/documentation-website/tree/main/_search-plugins/caching