Fix flaky test RemotePrimaryLocalRecoveryIT #18230
Open
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
sachinpkale
reviewed
May 7, 2025
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for a19b834: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
approved these changes
May 7, 2025
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
flaky-test-fix-remote-primary-local-recovery
branch
from
a19b834 to
2491e5d
Compare
Contributor
|
❌ Gradle check result for 2491e5d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
|
Github check is failing |
Member
|
@skumawat2025 Any update here? |
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky RemotePrimaryLocalRecoveryIT by limiting rolling restarts to data nodes
Problem:
RemotePrimaryLocalRecoveryIT was failing intermittently due to ClusterManagerNotDiscoveredException during rolling restarts that included master nodes. Test failed within 100 iterations due to cluster manager discovery issues. The test only needs to verify remote migration local recovery after data node restarts.
Solution:
Modified rolling restart logic to only restart data nodes, excluding master nodes from the restart sequence. This change has proven stable across 800+ test iterations.
Related Issues
Resolves #14314
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.