Skip to content

Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows #17873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows #17873

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b199b
Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows
reta Apr 10, 2025
a10b502
Added NetPermission check for UNIX Domain Socket deletion on Windows
reta Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ public static void intercept(@Advice.AllArguments Object[] args, @Advice.Origin
boolean isMutating = name.equals("move") || name.equals("write") || name.startsWith("create");
final boolean isDelete = isMutating == false ? name.startsWith("delete") : false;

// This is Windows implementation of UNIX Domain Sockets (close)
if (walker.getCallerClass().getName().equalsIgnoreCase("sun.nio.ch.PipeImpl$Initializer$LoopbackConnector") == true) {
return;
}

String targetFilePath = null;
if (isMutating == false && isDelete == false) {
if (name.equals("newByteChannel") == true || name.equals("open") == true) {
Expand Down
Loading