Skip to content

Conversation

@guojialiang92
Copy link
Contributor

Description

This PR solves the problem raised by issue 10764.
In the comments of the issue, I added the detailed process of reproducing the problem.

Related Issues

Resolves #[10764]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for bf0f8c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: guojialiang <[email protected]>
@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from bf0f8c8 to 2e4c3b6 Compare April 8, 2025 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❕ Gradle check result for 2e4c3b6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (7b6108b) to head (7d786a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17831      +/-   ##
============================================
- Coverage     72.44%   72.40%   -0.05%     
+ Complexity    66483    66396      -87     
============================================
  Files          5409     5409              
  Lines        308282   308283       +1     
  Branches      44759    44760       +1     
============================================
- Hits         223344   223198     -146     
- Misses        66608    66767     +159     
+ Partials      18330    18318      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for d97b873: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from d97b873 to d2260c3 Compare April 9, 2025 03:46
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for d2260c3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for d2260c3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Copy link
Member

mch2 commented Apr 9, 2025

thanks for the change @guojialiang92, would you please push a rebase and we can get this merged.

@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from d2260c3 to 77167a7 Compare April 9, 2025 06:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for 77167a7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from 77167a7 to d262dc3 Compare April 9, 2025 07:45
Signed-off-by: guojialiang <[email protected]>
@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from d262dc3 to b382f4e Compare April 9, 2025 08:50
@guojialiang92
Copy link
Contributor Author

Thanks, @mch2
I have tried rebase several times, but Gradle Check still hasn't passed. Can you help me take a look?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for aa0fa4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: guojialiang <[email protected]>
@guojialiang92 guojialiang92 force-pushed the dev/avoid-skewed-lag-metric branch from aa0fa4b to 7d786a8 Compare April 9, 2025 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

✅ Gradle check result for 7d786a8: SUCCESS

@mch2 mch2 merged commit 396add1 into opensearch-project:main Apr 9, 2025
31 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
…ensearch-project#17831)

* avoid skewed sr lag metric

Signed-off-by: guojialiang <[email protected]>

* add CHANGELOG

Signed-off-by: guojialiang <[email protected]>

* add test

Signed-off-by: guojialiang <[email protected]>

---------

Signed-off-by: guojialiang <[email protected]>
Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ensearch-project#17831)

* avoid skewed sr lag metric

Signed-off-by: guojialiang <[email protected]>

* add CHANGELOG

Signed-off-by: guojialiang <[email protected]>

* add test

Signed-off-by: guojialiang <[email protected]>

---------

Signed-off-by: guojialiang <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ensearch-project#17831)

* avoid skewed sr lag metric

Signed-off-by: guojialiang <[email protected]>

* add CHANGELOG

Signed-off-by: guojialiang <[email protected]>

* add test

Signed-off-by: guojialiang <[email protected]>

---------

Signed-off-by: guojialiang <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants