Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Apr 7, 2025

Description

Fix FileInterceptor to deduct the access level from the list of OpenOption

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

✅ Gradle check result for a45bb4d: SUCCESS

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (cd266f3) to head (a45bb4d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/javaagent/FileInterceptor.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17816      +/-   ##
============================================
- Coverage     72.55%   72.48%   -0.07%     
+ Complexity    66502    66499       -3     
============================================
  Files          5399     5399              
  Lines        307755   307757       +2     
  Branches      44656    44656              
============================================
- Hits         223295   223089     -206     
- Misses        66266    66464     +198     
- Partials      18194    18204      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix FileInterceptor to deduct the access level from the list of OpenOption

Should this be "deduce" instead of "deduct"?

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified manually that this fixes the startup issue when running with the agent.

@andrross andrross merged commit b0bfdc7 into opensearch-project:main Apr 7, 2025
58 of 62 checks passed
@andrross andrross changed the title Fix FileInterceptor to deduct the access level from the list of OpenOption Fix FileInterceptor to deduce the access level from the list of OpenOption Apr 7, 2025
guojialiang92 pushed a commit to guojialiang92/OpenSearch that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants