Skip to content

Conversation

@mulugetam
Copy link
Contributor

@mulugetam mulugetam commented Mar 24, 2025

Description

Bumped up the ZSTD library to version 1.5.6-1. This version adds support for custom sequence producers, which makes it possible to add Intel® QAT-accelerated ZSTD in custom-codecs—on top of the existing qat_deflate and qat_lz4. A similar PR is made for custom-codecs.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for a825f9f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sarthakaggarwal97
Copy link
Contributor

@mulugetam there are few PR checks failing that might need a fix.

@github-actions
Copy link
Contributor

❌ Gradle check result for e38dc9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Contributor

reta commented Mar 28, 2025

@reta @sarthakaggarwal97 When should we expect this to get merged?

@mulugetam sure, could you please rebase and fix conflicts? thank you

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sarthakaggarwal97
Copy link
Contributor

sarthakaggarwal97 commented Mar 28, 2025

@reta looks like gradle checks didn't run properly, maybe you can retry the failed tasks.

@reta
Copy link
Contributor

reta commented Mar 28, 2025

@reta looks like gradle checks didn't run properly, maybe you can retry the failed tasks.

@sarthakaggarwal97 did it ~4 times already ... :(

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6530bc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 6530bc9: SUCCESS

@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (f4b8393) to head (6530bc9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17674      +/-   ##
============================================
- Coverage     72.41%   72.29%   -0.13%     
+ Complexity    65880    65754     -126     
============================================
  Files          5326     5326              
  Lines        305548   305548              
  Branches      44322    44322              
============================================
- Hits         221258   220882     -376     
- Misses        66101    66533     +432     
+ Partials      18189    18133      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta merged commit e0a67fd into opensearch-project:main Mar 29, 2025
31 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Mar 29, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0a67fd9ca949b14b90dc206231d90158bc35b38
# Push it to GitHub
git push --set-upstream origin backport/backport-17674-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-17674-to-2.x.

@mulugetam
Copy link
Contributor Author

@reta @sarthakaggarwal97 thank you!

mulugetam added a commit to mulugetam/OpenSearch that referenced this pull request May 28, 2025
* Bump ZSTD lib to version 1.5.6-1.

Signed-off-by: Mulugeta Mammo <[email protected]>

* Update CHANGELOG.md for ZSTD version bump.

Signed-off-by: Mulugeta Mammo <[email protected]>

* Update zstd-jni SHA.

Signed-off-by: Mulugeta Mammo <[email protected]>

---------

Signed-off-by: Mulugeta Mammo <[email protected]>
Signed-off-by: mulugetam <[email protected]>
mulugetam added a commit to mulugetam/OpenSearch that referenced this pull request May 28, 2025
* Bump ZSTD lib to version 1.5.6-1.

Signed-off-by: Mulugeta Mammo <[email protected]>

* Update CHANGELOG.md for ZSTD version bump.

Signed-off-by: Mulugeta Mammo <[email protected]>

* Update zstd-jni SHA.

Signed-off-by: Mulugeta Mammo <[email protected]>

---------

Signed-off-by: Mulugeta Mammo <[email protected]>
Signed-off-by: mulugetam <[email protected]>
@mulugetam
Copy link
Contributor Author

@reta Have submitted #18388 to manually backport to 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch backport-failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants