Skip to content

Conversation

@vinaykpud
Copy link
Contributor

Description

This PR adds allocation awareness and awareness balance support for search replica

Related Issues

Resolves #16987
Resolves #17330
Related #15306

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Performance labels Mar 21, 2025
@github-actions
Copy link
Contributor

✅ Gradle check result for 4d100fd: SUCCESS

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (8182bb0) to head (23600db).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...luster/metadata/MetadataUpdateSettingsService.java 28.57% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17652      +/-   ##
============================================
+ Coverage     72.29%   72.39%   +0.10%     
- Complexity    65900    66026     +126     
============================================
  Files          5350     5350              
  Lines        306185   306208      +23     
  Branches      44373    44375       +2     
============================================
+ Hits         221347   221681     +334     
+ Misses        66670    66438     -232     
+ Partials      18168    18089      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 5bdf41d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 5bdf41d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

❌ Gradle check result for 2239ec7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud closed this Mar 27, 2025
@vinaykpud vinaykpud reopened this Mar 27, 2025
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 69ad375: SUCCESS

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 23600db: SUCCESS

@mch2 mch2 merged commit 0eabc79 into opensearch-project:main Mar 31, 2025
34 of 35 checks passed
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Apr 1, 2025
…17652)

* Added allocation awareness attribute support for search replica

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Support allocation awareness balance for search replica

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Updated awareness balance condition

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Address PR comments

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* updated the if condition check

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* changes based on the PR comments, reducing diffs

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* reducing the diffs

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* removed unnecessary static keyword

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

---------

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search:Performance skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RW Separation] Search replica need to be counted for allocation awareness balance [RW Separation] Honor allocation awareness attributes

2 participants