Add search backpressure service check for query group tasks #17576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalmahi12
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
bug
Contributor
|
❌ Gradle check result for 3dcb827: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 3dcb827: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jainankitk
reviewed
Mar 12, 2025
This was referenced Mar 13, 2025
jainankitk
approved these changes
Mar 13, 2025
Contributor
|
❌ Gradle check result for b165076: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
force-pushed
the
wlm/warnlog-fix
branch
from
b165076 to
fb34b94
Compare
Contributor
|
❌ Gradle check result for fb34b94: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Looks unrelated: |
Contributor
|
Retrying gradle check |
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17576 +/- ##
============================================
+ Coverage 72.43% 72.44% +0.01%
- Complexity 65694 65718 +24
============================================
Files 5311 5311
Lines 304937 304934 -3
Branches 44226 44225 -1
============================================
+ Hits 220872 220918 +46
+ Misses 65912 65907 -5
+ Partials 18153 18109 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Mar 14, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
* add validation check for SBP service Signed-off-by: Kaushal Kumar <[email protected]> * add SBP should not handle the task tracking UT Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix broken UT Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> (cherry picked from commit 8ee5eeb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 15, 2025
Open
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-17576-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ee5eebc3728a19487c0604d9828f92770fcd7ec
# Push it to GitHub
git push --set-upstream origin backport/backport-17576-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19Then, create a pull request where the |
jainankitk
pushed a commit
that referenced
this pull request
Mar 17, 2025
…17591) * add validation check for SBP service * add SBP should not handle the task tracking UT * add CHANGELOG entry * fix broken UT * address comments --------- (cherry picked from commit 8ee5eeb) Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12
added a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Mar 17, 2025
…ch-project#17576) * add validation check for SBP service Signed-off-by: Kaushal Kumar <[email protected]> * add SBP should not handle the task tracking UT Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix broken UT Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
jainankitk
pushed a commit
that referenced
this pull request
Mar 18, 2025
…17613) * add validation check for SBP service * add SBP should not handle the task tracking UT * add CHANGELOG entry * fix broken UT * address comments --------- Signed-off-by: Kaushal Kumar <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
…ch-project#17576) * add validation check for SBP service Signed-off-by: Kaushal Kumar <[email protected]> * add SBP should not handle the task tracking UT Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix broken UT Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to address the bug when search backpressure service is gathering the node stats and there are
QueryGroupTasks in the system which doesn't have the queryGroupId set. In this case there will be a NPE thrown for node stats due to this line.But this will only happen for 2.x versions since they don't have the scroll API changes for setting the queryGroupId #17169. We had to remove the API change because of the backward compatibility failure which was blocking the merge but later maintainers removed the check for internalApi annotated classes since they are not meant to be used outside of opensearch core.
I will also add that change in 2.x subsequently.
Related Issues
Resolves #17518 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.