-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based Ingestion] Add error handling strategy to pull-based ingestion #17427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Add error handling strategy to pull-based ingestion #17427
Conversation
|
❌ Gradle check result for dc4722f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/metadata/IngestionSource.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/MessageProcessorRunnable.java
Show resolved
Hide resolved
dc4722f to
d0168ee
Compare
d0168ee to
1b61879
Compare
|
❌ Gradle check result for 1b61879: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1b61879 to
7eee397
Compare
|
❌ Gradle check result for 7eee397: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7eee397 to
474008b
Compare
|
❌ Gradle check result for 474008b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 6dc359a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6dc359a to
441b463
Compare
|
❌ Gradle check result for 441b463: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @varunbharadwaj. Can you add a changelog entry in CHANGELOG-3.0.md and also rebase this with the latest on main?
441b463 to
1904e14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17427 +/- ##
============================================
+ Coverage 72.46% 72.51% +0.04%
- Complexity 65707 65739 +32
============================================
Files 5307 5310 +3
Lines 304774 304825 +51
Branches 44193 44196 +3
============================================
+ Hits 220850 221033 +183
+ Misses 65898 65766 -132
Partials 18026 18026 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
1904e14 to
a431b14
Compare
Sure, updated. Please take a look. |
|
LGTM |
…stion (opensearch-project#17427) * Add error handling strategy to pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Make error strategy config type-safe Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]>
…stion (opensearch-project#17427) * Add error handling strategy to pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Make error strategy config type-safe Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Description
This PR is a follow up for pull-based-ingestion to add error handling support. We introduce the following two strategies:
This PR adds the drop/block support along with required interfaces. A follow up PR will add metric emission and record the errors.
When using Block strategy, we need a way to allow users to resume ingestion. Ingestion management APIs will be added to allow users more flexibility as part of #17442
Related Issues
Resolves #17085
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.