Introduce execution hint for Cardinality aggregation #17301
Conversation
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Siddharth Rayabharam <[email protected]>
asimmahmood1
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
ashking94,
cwperks,
dblock,
dbwiddis and
gbbafna
as code owners
asimmahmood1
requested review from
Rishikesh1159,
VachaShah,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
enhancement
| if (hasPrecisionThreshold) { | ||
| out.writeLong(precisionThreshold); | ||
| } | ||
| out.writeOptionalString(executionHint); |
There was a problem hiding this comment.
When making ser/de changes there can be issues in mixed clusters (fe during B/G) if this object is serialized to an older node that doesn't understand the value. In such cases, the serialization logic can check the target version (example) to see if the target node is of an older version and exclude it from serialization.
Similarly when deserializing if the request is coming from an older node then if you try to read the value from the StreamInput it will fail.
There was a problem hiding this comment.
Ah, good point, will update.
* This PR is reviving opensearch-project#15764 Signed-off-by: Asim Mahmood <[email protected]>
| * @opensearch.internal | ||
| */ | ||
| private static class DirectCollector extends Collector { | ||
| public static class DirectCollector extends Collector { |
|
❌ Gradle check result for c582cdc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f4c2e05: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Closing this PR, it has double commit message, going to recreate a new PR. |
3 participants
Description
Introduce execution hint for Cardinality aggregation - Revive PR #15764
Related Issues
Resolves #15269
Check List
Testing
Tested using big5 dataset, see #16837 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.