-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Rule-based Auto Tagging] Add rule schema for auto tagging #17238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc12186 to
f6a4a28
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17238 +/- ##
============================================
- Coverage 72.53% 72.36% -0.18%
+ Complexity 65826 65741 -85
============================================
Files 5311 5316 +5
Lines 305073 305281 +208
Branches 44243 44287 +44
============================================
- Hits 221293 220912 -381
- Misses 65688 66197 +509
- Partials 18092 18172 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
094c95d to
bb8d06c
Compare
5c7de13 to
108ae79
Compare
|
❕ Gradle check result for 108ae79: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
108ae79 to
8f106ae
Compare
|
❕ Gradle check result for 8f106ae: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sgup432
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the change
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17238-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b24c72b06bfd76d7d1d134a9ec9804965ad74352
# Push it to GitHub
git push --set-upstream origin backport/backport-17238-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
…h-project#17238) Signed-off-by: Ruirui Zhang <[email protected]> * add rule schema for workload management Signed-off-by: Ruirui Zhang <[email protected]> * modify rule structure based on comment Signed-off-by: Ruirui Zhang <[email protected]> * update based on comments Signed-off-by: Ruirui Zhang <[email protected]> * add javadoc for autotagging directory Signed-off-by: Ruirui Zhang <[email protected]> * change field name from 'name' to 'description' Signed-off-by: Ruirui Zhang <[email protected]> * update the rule schema Signed-off-by: Ruirui Zhang <[email protected]> * simplify autotagging registry Signed-off-by: Ruirui Zhang <[email protected]> * remove generic type parameter from Rule class Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> (cherry picked from commit b24c72b)
…17653) Signed-off-by: Ruirui Zhang <[email protected]> * add rule schema for workload management Signed-off-by: Ruirui Zhang <[email protected]> * modify rule structure based on comment Signed-off-by: Ruirui Zhang <[email protected]> * update based on comments Signed-off-by: Ruirui Zhang <[email protected]> * add javadoc for autotagging directory Signed-off-by: Ruirui Zhang <[email protected]> * change field name from 'name' to 'description' Signed-off-by: Ruirui Zhang <[email protected]> * update the rule schema Signed-off-by: Ruirui Zhang <[email protected]> * simplify autotagging registry Signed-off-by: Ruirui Zhang <[email protected]> * remove generic type parameter from Rule class Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> (cherry picked from commit b24c72b) Signed-off-by: Ruirui Zhang <[email protected]>
…h-project#17238) * add rule schema for workload management Signed-off-by: Ruirui Zhang <[email protected]> * modify rule structure based on comment Signed-off-by: Ruirui Zhang <[email protected]> * update based on comments Signed-off-by: Ruirui Zhang <[email protected]> * add javadoc for autotagging directory Signed-off-by: Ruirui Zhang <[email protected]> * change field name from 'name' to 'description' Signed-off-by: Ruirui Zhang <[email protected]> * update the rule schema Signed-off-by: Ruirui Zhang <[email protected]> * simplify autotagging registry Signed-off-by: Ruirui Zhang <[email protected]> * remove generic type parameter from Rule class Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]>
Description
This PR introduces the schema for Rule object used in the auto tagging feature. A single rule will only have one feature but could have multiple attributes.
For the example below, the feature is query_group, and corresponds to the tag dev_query_group_id
Related issues:
RFC: #16797
#16813
Check List