-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[JPMS Support] Refactor :libs module bootstrap package to eliminate top level split packages
#17117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@reta @andrross can you please check and provide your thoughts ? |
|
❌ Gradle check result for 6c17381: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6c17381 to
70b105a
Compare
|
❌ Gradle check result for 70b105a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
70b105a to
4047be3
Compare
|
❌ Gradle check result for 4047be3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4047be3 to
7c38379
Compare
|
From #8110:
Why did you move the classes in |
|
❌ Gradle check result for 7c38379: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7c38379 to
77e91c2
Compare
|
❌ Gradle check result for faa0ee7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Initially I thought of parking I have updated this PR back to |
faa0ee7 to
bb5c763
Compare
|
❌ Gradle check result for bb5c763: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bb5c763 to
90a1d17
Compare
:server module bootstrap package to eliminate top level split packages:libs module bootstrap package to eliminate top level split packages
|
❌ Gradle check result for 90a1d17: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
I think it looks better this way @prudhvigodithi , thank you! |
|
❕ Gradle check result for 90a1d17: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17117 +/- ##
============================================
+ Coverage 72.30% 72.36% +0.05%
- Complexity 65482 65486 +4
============================================
Files 5309 5309
Lines 304324 304347 +23
Branches 44132 44141 +9
============================================
+ Hits 220056 220241 +185
+ Misses 66259 66081 -178
- Partials 18009 18025 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Prudhvi Godithi <[email protected]>
90a1d17 to
31fb88c
Compare
|
❕ Gradle check result for 31fb88c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: expani <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: Eugene Tolbakov <[email protected]>
Description
For Phase 0 - JPMS Support, refactor
:libsmodulebootstrappackage to eliminate top level split packages.The
:libs:opensearch-commonand:servermodule both hasorg.opensearch.bootstrap. Updated the:libsorg.opensearch.bootstraptoorg.opensearch.common.bootstrap.Related Issues
Part of #8110
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.