Skip to content

[Backport 2.x] Improve performance of the bitmap filtering #17082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

[Backport 2.x] Improve performance of the bitmap filtering #17082

merged 1 commit into from
Jan 22, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jan 22, 2025

Backport ba0c4f3 from #16936.

@github-actions
Improve performance of bitmap terms filtering (#16936)
72ac22b 
---------

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit ba0c4f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

❕ Gradle check result for 72ac22b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.26214% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (bd885f7) to head (72ac22b).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../org/opensearch/search/query/BitmapIndexQuery.java 90.72% 3 Missing and 6 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17082      +/-   ##
============================================
+ Coverage     71.84%   71.93%   +0.08%     
- Complexity    65595    65636      +41     
============================================
  Files          5318     5319       +1     
  Lines        305846   305930      +84     
  Branches      44602    44615      +13     
============================================
+ Hits         219739   220074     +335     
+ Misses        67752    67561     -191     
+ Partials      18355    18295      -60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 22, 2025
Open
@andrross andrross merged commit a48aa73 into 2.x Jan 22, 2025
61 of 62 checks passed
@andrross andrross deleted the backport/backport-16936-to-2.x branch January 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrross