Skip to content

Update version checks for backport #17030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update version checks for backport #17030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...api-spec/src/main/resources/rest-api-spec/test/search.aggregation/70_adjacency_matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ setup:
---
"Show only intersections":
- skip:
version: " - 2.99.99"
reason: "show_only_intersecting was added in 3.0.0"
version: " - 2.19.0"
reason: "show_only_intersecting was added in 2.19.0"
features: node_selector
- do:
node_selector:
version: "3.0.0 - "
version: "2.19.0 - "
search:
index: test
rest_total_hits_as_int: true
Expand Down
4 changes: 2 additions & 2 deletions ...rg/opensearch/search/aggregations/bucket/adjacency/AdjacencyMatrixAggregationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public AdjacencyMatrixAggregationBuilder(StreamInput in) throws IOException {
super(in);
int filtersSize = in.readVInt();
separator = in.readString();
if (in.getVersion().onOrAfter(Version.V_3_0_0)) {
if (in.getVersion().onOrAfter(Version.V_2_19_0)) {
showOnlyIntersecting = in.readBoolean();
}
filters = new ArrayList<>(filtersSize);
Expand All @@ -201,7 +201,7 @@ public AdjacencyMatrixAggregationBuilder(StreamInput in) throws IOException {
protected void doWriteTo(StreamOutput out) throws IOException {
out.writeVInt(filters.size());
out.writeString(separator);
if (out.getVersion().onOrAfter(Version.V_3_0_0)) {
if (out.getVersion().onOrAfter(Version.V_2_19_0)) {
out.writeBoolean(showOnlyIntersecting);
}
for (KeyedFilter keyedFilter : filters) {
Expand Down
Loading