-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix getTime field name to time in GetStats (#16894) #17009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reta
merged 11 commits into
opensearch-project:main
from
hye-on:fix-get-stats-time-field
Jan 17, 2025
+46
−1
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dde2608
Fix getTime field name to time in GetStats (#16894)
hye-on 1bb5cc3
Update PR number in changelog
hye-on d675a02
Deprecate getTime field and add time field in GetStats for backward c…
hye-on 492767f
Add forRemoval flag to getTime field for future removal
hye-on b18d415
Changed to use field instead of humanReadableField for GET_TIME in JS…
hye-on 98c8a62
Add test to validate getTime and time fields in _stats API response
hye-on 40ac728
Fix formatting in GetStats.java
hye-on 2b546d2
Rename test file to better reflect test purpose
hye-on 3b30e33
Test Add skip version for stats API human filter test under 2.19.99
hye-on 2754fcb
Remove unnecessary changelog entries
hye-on 01b7905
Add a line for styling purposes
hye-on File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
.../resources/rest-api-spec/test/indices.stats/60_include_both_time_and_gettime_in_stats.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --- | ||
| setup: | ||
| - do: | ||
| indices.create: | ||
| index: test1 | ||
| body: | ||
| settings: | ||
| number_of_shards: 1 | ||
| number_of_replicas: 0 | ||
| wait_for_active_shards: all | ||
|
|
||
| - do: | ||
| index: | ||
| index: test1 | ||
| id: 1 | ||
| body: { "foo": "bar" } | ||
|
|
||
| - do: | ||
| indices.refresh: | ||
| index: test1 | ||
|
|
||
| --- | ||
| "Test _stats API includes both time and getTime metrics with human filter": | ||
| - skip: | ||
| version: " - 2.19.99" | ||
| reason: "this change is added in 3.0.0" | ||
|
|
||
| - do: | ||
| indices.stats: | ||
| metric: [ get ] | ||
| human: true | ||
|
|
||
| - is_true: _all.primaries.get.time | ||
| - is_true: _all.primaries.get.getTime | ||
| - match: { _all.primaries.get.time: "0s" } | ||
| - match: { _all.primaries.get.getTime: "0s" } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.