Skip to content

[Backport 2.x] Fix non-x64 bwc build targets #16584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

[Backport 2.x] Fix non-x64 bwc build targets #16584

merged 1 commit into from
Nov 6, 2024

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Nov 6, 2024

Backport 9f790ee from #16575.

@github-actions
Fix non-x64 bwc build targets (#16575)
d0d98ac 
There were a few issues here: the '-x64' suffix was being unconditionally
appeneded, debian uses underscores not hyphens, and the rpm target uses the
'.86_64' suffix.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 9f790ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Gradle check result for d0d98ac: SUCCESS

@codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (dc4a5f4) to head (d0d98ac).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...e/internal/InternalDistributionBwcSetupPlugin.java 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16584      +/-   ##
============================================
+ Coverage     71.78%   71.85%   +0.06%     
- Complexity    65361    65385      +24     
============================================
  Files          5313     5313              
  Lines        305089   305102      +13     
  Branches      44452    44454       +2     
============================================
+ Hits         219015   219219     +204     
+ Misses        67796    67582     -214     
- Partials      18278    18301      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit a957ded into 2.x Nov 6, 2024
63 of 65 checks passed
@andrross andrross deleted the backport/backport-16575-to-2.x branch November 6, 2024 21:05
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reta @andrross