Update TESTING.md 'Building with extra plugins' documentation #15893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnegancarroll
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
dblock
suggested changes
Sep 11, 2024
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Looks good, just needs a TOC update. Thanks for doing this!
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
finnegancarroll
force-pushed
the
buildplug
branch
from
7e2aaa0 to
9a7c3d5
Compare
Contributor
|
❌ Gradle check result for 7e2aaa0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dblock
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]> (cherry picked from commit 36c89bf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
It's a markdown change, apologies if I was not supposed to merge without retrying gradle check here. |
dblock
pushed a commit
that referenced
this pull request
Sep 13, 2024
#15933) * Update TESTING.md 'Building with extra plugins' documentation * Typo * Fix TOC --------- (cherry picked from commit 36c89bf) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 19, 2024
…arch-project#15893) * Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…arch-project#15893) * Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…arch-project#15893) * Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…arch-project#15893) * Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…arch-project#15893) * Update TESTING.md 'Building with extra plugins' documentation Signed-off-by: Finn Carroll <[email protected]> * Typo Signed-off-by: Finn Carroll <[email protected]> * Fix TOC Signed-off-by: Finn Carroll <[email protected]> --------- Signed-off-by: Finn Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Building with extra plugins" section of TESTING.md is stale. Updating docs to reflect plugin documentation.
Related Issues
#15847
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.