Skip to content

[Backport 2.x] Add prefix support to hashed prefix & infix path types on remote store #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2024
Merged

[Backport 2.x] Add prefix support to hashed prefix & infix path types on remote store #15668

merged 6 commits into from
Sep 5, 2024

Conversation

@ashking94
Copy link
Member

@ashking94 ashking94 commented Sep 4, 2024

Backport 33be5a9 from #15557

@ashking94
Add prefix support to hashed prefix & infix path types on remote store (
9581efc 
opensearch-project#15557)

* Add prefix support to hashed prefix & infix path types on remote store

Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 9581efc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
fix compilation issue
df8fe27 
Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for df8fe27: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Fix breaking changes
a05496f 
Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for a05496f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for a05496f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for a05496f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Copy link
Member

sachinpkale commented Sep 4, 2024

Pre-commit is failing due to following:

> Task :server:compileTestJava
            List.of(new RemoteIndexPathUploader(threadPool, newSettings, repositoriesServiceSupplier, clusterSettings)),
                    ^
  required: ThreadPool,Settings,Supplier<RepositoriesService>,ClusterSettings,RemoteStoreSettings
  found:    ThreadPool,Settings,Supplier<RepositoriesService>,ClusterSettings
  reason: actual and formal argument lists differ in length

@ashking94
Copy link
Member Author

ashking94 commented Sep 4, 2024

Pre-commit is failing due to following:

> Task :server:compileTestJava
            List.of(new RemoteIndexPathUploader(threadPool, newSettings, repositoriesServiceSupplier, clusterSettings)),
                    ^
  required: ThreadPool,Settings,Supplier<RepositoriesService>,ClusterSettings,RemoteStoreSettings
  found:    ThreadPool,Settings,Supplier<RepositoriesService>,ClusterSettings
  reason: actual and formal argument lists differ in length

@sachinpkale - these have been fixed earlier. Once the jenkins build pass, we should be able to merge it.

@ashking94
Empty-Commit
2c27a4f 
Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 2c27a4f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 2c27a4f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 2c27a4f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for c38e769: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for a05496f: SUCCESS

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for c38e769: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Fix test
639ee98 
Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for 639ee98: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (5875393) to head (639ee98).
Report is 18 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ore/lockmanager/RemoteStoreLockManagerFactory.java 62.50% 3 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 0.00% 2 Missing ⚠️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 66.66% 2 Missing ⚠️
...ries/cleanup/TransportCleanupRepositoryAction.java 66.66% 1 Missing ⚠️
...ensearch/index/remote/RemoteStorePathStrategy.java 80.00% 1 Missing ⚠️
server/src/main/java/org/opensearch/node/Node.java 75.00% 1 Missing ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 50.00% 1 Missing ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15668      +/-   ##
============================================
- Coverage     71.70%   71.59%   -0.12%     
- Complexity    64104    64113       +9     
============================================
  Files          5249     5251       +2     
  Lines        299681   300465     +784     
  Branches      43643    43726      +83     
============================================
+ Hits         214876   215103     +227     
- Misses        66848    67307     +459     
- Partials      17957    18055      +98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit ba11fb9 into opensearch-project:2.x Sep 5, 2024
This was referenced Sep 6, 2024
Open
Closed
Open
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 28, 2024
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashking94 @sachinpkale