Skip to content

[Backport 2.x] Make balanced shards allocator timebound #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2024
Merged

[Backport 2.x] Make balanced shards allocator timebound #15503

merged 1 commit into from
Aug 29, 2024

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 29, 2024

Backport e982a16 from #15239.

@github-actions
Make balanced shards allocator timebound (#15239)
ca39e4e 
* Make balanced shards allocator time bound to prioritise critical operations waiting in the pending task queue

Signed-off-by: Rishab Nahata <[email protected]>
(cherry picked from commit e982a16)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024

✅ Gradle check result for ca39e4e: SUCCESS

@codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.61%. Comparing base (4ec2c5d) to head (ca39e4e).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../allocation/allocator/BalancedShardsAllocator.java 76.47% 3 Missing and 1 partial ⚠️
...ting/allocation/allocator/LocalShardsBalancer.java 78.94% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15503      +/-   ##
============================================
- Coverage     71.67%   71.61%   -0.07%     
+ Complexity    63602    63593       -9     
============================================
  Files          5221     5221              
  Lines        297593   297630      +37     
  Branches      43314    43322       +8     
============================================
- Hits         213302   213136     -166     
- Misses        66521    66660     +139     
- Partials      17770    17834      +64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 1d218da into 2.x Aug 29, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
@andrross andrross deleted the backport/backport-15239-to-2.x branch October 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bukhtawar