[Backport 2.x] Add ThreadContextPermission for markAsSystemContext and allow core to perform the method #15035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… perform the method (#15016) * Add RuntimePermission for markAsSystemContext and allow core to perform the method Signed-off-by: Craig Perkins <[email protected]> * private Signed-off-by: Craig Perkins <[email protected]> * Surround with doPrivileged Signed-off-by: Craig Perkins <[email protected]> * Create ThreadContextAccess Signed-off-by: Craig Perkins <[email protected]> * Create notion of ThreadContextPermission Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Add javadoc Signed-off-by: Craig Perkins <[email protected]> * Add to test-framework.policy file Signed-off-by: Craig Perkins <[email protected]> * Mark as internal Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 597747d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
reta
requested changes
Jul 31, 2024
| * permission org.opensearch.secure_sm.ThreadContextPermission "markAsSystemContext"; | ||
| */ | ||
| public void markAsSystemContext() { | ||
| SecurityManager sm = System.getSecurityManager(); |
Contributor
There was a problem hiding this comment.
As we discussed (#15016 (comment)), we need to make this change backward compatible
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15035 +/- ##
============================================
+ Coverage 71.48% 71.55% +0.06%
- Complexity 62677 62733 +56
============================================
Files 5123 5125 +2
Lines 294480 294538 +58
Branches 42912 42921 +9
============================================
+ Hits 210518 210747 +229
+ Misses 66286 66147 -139
+ Partials 17676 17644 -32 ☔ View full report in Codecov by Sentry. |
Member
Contributor
|
Closing in favour of #15038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 597747d from #15016.