[Backport 2.x] Fix read/write in stream method for Diff Manifest when shard diff file is null #14947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shailendra Singh <[email protected]>
shailendra0811
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
shailendra0811
changed the title
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14947 +/- ##
============================================
- Coverage 71.66% 71.50% -0.16%
+ Complexity 62739 62680 -59
============================================
Files 5120 5121 +1
Lines 294255 294266 +11
Branches 42877 42880 +3
============================================
- Hits 210871 210415 -456
- Misses 65668 66181 +513
+ Partials 17716 17670 -46 ☔ View full report in Codecov by Sentry. |
Bukhtawar
approved these changes
Jul 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ll (#14947) Signed-off-by: Shailendra Singh <[email protected]> (cherry picked from commit 82c4c1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ll (#14947) (#14951) (cherry picked from commit 82c4c1e) Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5744eae from #14938